MTA-4746: tidy up attributes to remove MTR attributes #101
Conversation
Signed-off-by: A.Arnold <[email protected]>
|
@istein1 - please can you review for PR @raoradhika - please can you review for Docs @fbladilo - please can you do a quick sanity check for me (I know you are crazy busy) so if you do not have time, cool enough |
|
@istein1 - do you want me to bump the OCP version to 4.18 with the PR? |
| @@ -30,40 +29,14 @@ ifdef::mta[] | |||
| :ProductDistributionVersion: 7.2.1.GA-redhat | |||
| :ProductDistribution: mta-7.2.1.GA-cli-offline.zip | |||
| :DevDownloadPageURL: https://developers.redhat.com/products/mta/download | |||
| :IDEPluginFilename: migrationtoolkit-mta-eclipse-plugin-repository | |||
There was a problem hiding this comment.
All changes in this PR LGTM except for removed lines 33, 35 - I am not sure what these are
There was a problem hiding this comment.
@istein1 - these look like they were used in MTR, not MTA
I double-checked and removed everything with 0 occurrences
Yes please. OCP 4.18 was released already AFAIK. It was tested by QE along with MTA 7.2.1. |
| :ocp-version: 4.17 | ||
| :ocp-supported: 4.17, 4.16, 4.15 | ||
| :ocp-version: 4.18 | ||
| :ocp-supported: 4.18, 4.17, 4.16, 4.15 |
There was a problem hiding this comment.
Could you please remove 4.15?
We support (/test) only 2 versions backwards.
|
I'm not sure I'm the right contact to review this but looks sane for at least the pieces that I have knowledge of |
JIRA
DESCRIPTION
With this PR, I want to remove the MTR attributes
I have been through the docs and done bulk searches for each attribute in the MTA docs (we have removed the MTR docs in this MTA-2951: Remove MTR files from MTA repo, so have been able to test the documentation)